fix: redesign compaction to never alter chat history#67
Merged
platypusrex merged 1 commit intomainfrom Feb 22, 2026
Merged
Conversation
Closes #61 Compaction has been fully redesigned so that chat history is never altered. Compaction only affects what gets sent to the model. Part A — Compaction redesign: - Add summary_message_id to sessions table (migration v4), drop message_snapshots - Remove all snapshot CRUD and fromOllamaMessages (~180 lines) - Split message store: displayMessages (full history) vs history (summary-aware slice) - Summarizer as separate Ollama call with structured 6-section prompt - CompactionSummaryPart renders inline in chat Part B — Token accuracy (core fix): - Agent loop uses real prompt_eval_count from model for compaction decisions - buildContextUsage() prefers real token counts over heuristic - Sidebar preserves real counts (hasRealCounts flag prevents heuristic overwrite) - CHARS_PER_TOKEN.mixed 3→2.5, OVERHEAD_AGENT_LOOP 4k→6k Part C — Auto-compaction trigger: - Agent returns needsSummarization flag (caller handles summarization) - promptTooLong detection with auto-retry (summarize then re-submit) - Post-run auto-summarization when needsSummarization flag set - Manual /compact command calls summarizeConversation directly Remaining token accuracy improvements deferred to #64. Observational memory (hybrid approach) tracked in #65. Summary quality improvements tracked in #66.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summary_message_idon sessions)prompt_eval_countfrom model for compaction decisions instead of character heuristic aloneCloses #61
Follow-on issues
num_ctxparsing)