Skip to content

build: add cjs compatibility #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

build: add cjs compatibility #61

merged 1 commit into from
Mar 14, 2024

Conversation

markthree
Copy link
Contributor

fix #55 #44

use unbuild，simple and stable enough 🥰

@alexrabin
Copy link

@BruceMacD can you take a look at this please?

@saul-jb saul-jb mentioned this pull request Mar 14, 2024
Closed
BruceMacD
BruceMacD approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this is great. Tested it in a bunch of environments and the change itself is simple. I appreciate the help.

@BruceMacD BruceMacD merged commit 24d6c83 into ollama:main Mar 14, 2024
@paulsybrandy paulsybrandy mentioned this pull request Jul 7, 2024
Open
@PierreGode PierreGode mentioned this pull request Sep 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceMacD BruceMacD BruceMacD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error [ERR_REQUIRE_ESM]: require() of ES Module
3 participants
@markthree @alexrabin @BruceMacD