Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo ellipsis, added #628

Closed
wants to merge 8 commits into from
Closed

typo ellipsis, added #628

wants to merge 8 commits into from

Conversation

leela52452
Copy link
Contributor

@gedakc
Copy link
Collaborator

gedakc commented Sep 9, 2019

While reviewing this PR I came across several issues:

  • This PR seems to also include changes made in PR change markdown to "Markdown" in.... #624 and hence is a duplicate.
    To resolve either close one of the PRs, or else remove the duplicated changes from this PR. Note that PR's can be amended and re-pushed with the --force option.
  • Automatic checks can make mistakes. In this case I think at least one of the sentences contains mention of three periods "..." and should remain as three periods.
    • Replace ... with …
      When enabled this automatic translation ability in Manuskript will convert the writer's three periods into an ellipses.
  • All of the ellipses changes should be squashed into a single commit.

I highly recommend reviewing and testing all changes before submitting.

@gedakc
Copy link
Collaborator

gedakc commented Sep 16, 2019

In my search for Qt standards I came across the following document:

User Interface Text Guidelines

Following is a quote from these guidelines:

Punctuation

Avoid using punctuation marks or special characters in menu names and items.

Use punctuation marks as follows:

  • Use full stops in messages.
  • Never use full stops (.) at the end of menu item names.
  • Place three full stops (...) at the end of menu item names that open a dialog requiring user action.
  • Use exclamation marks (!) only in text that demands extra attention from the user or carries special weight.
  • Use quotation marks ("") around variable values. For example, Close Project "qtcreator". For consistency, use double quotes to emphasize or set apart file names, directory names, URLs, and so on, in user visible strings.
  • Do not use leading, trailing, or multiple spaces to align text in messages, as translation tools might not handle them correctly.

From reading the above I understand that ellipses are to be avoided in menu names and items.

If you have discovered documentation to the contrary then please share your findings.

@gedakc
Copy link
Collaborator

gedakc commented Sep 29, 2019

For the reasons outlined in an earlier post (E.g, place three full stops (...) at the end of menu item names that open a dialog requiring user action and don't use ellipses) I am closing this PR and labeling it as wontfix.

@gedakc gedakc closed this Sep 29, 2019
@gedakc gedakc added the wontfix label Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants