Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session target #460

Merged
merged 4 commits into from
Dec 10, 2022
Merged

Session target #460

merged 4 commits into from
Dec 10, 2022

Conversation

nephlm
Copy link
Contributor

@nephlm nephlm commented Jan 22, 2019

Adds a Tools menu Item that creates a non-modal window that tracks session and draft progress and goals.

screenshot at 2019-01-21 23 09 45

The data is updated every two seconds via a timer.

While I was doing this I noticed that the Frequency Counter window does not close when the main app closed. Fixed that at the same time, since I was using it as a model.

This is my first Qt development so there are likely things I did wrong in in regard to the framework so there are likely things I did wrong or at least sub-optimally. If you point them out, I'll be happy to fix them.

@gedakc
Copy link
Collaborator

gedakc commented Jan 24, 2019

Discussion can be found in feature request issue #459.

@nephlm
Copy link
Contributor Author

nephlm commented Nov 21, 2022

I wrote this like 4 years ago, but I merged in current develop and resolved the conflicts. Did some testing and it seems to still work without clobbering anything else. It's got an approval and is now up to date, I'm not sure who has merge power, but I think it can be merged.

@TheJackiMonster
Copy link
Collaborator

I'll look into it. Thanks for your effort. ^^

@TheJackiMonster TheJackiMonster added this to the 0.15.0 milestone Nov 21, 2022
…nd center dialog

Signed-off-by: TheJackiMonster <thejackimonster@gmail.com>
@TheJackiMonster
Copy link
Collaborator

I've adjusted some parts to prevent crashes in projects with no text files or one empty ones. I'm not even convinced this was an issue on your side but rather the defaults of the data structure we use being empty strings (which doesn't make any sense for word counts for example).

I've also centered the dialog on startup like the others. It can still be moved freely and updates while writing. So I think this can be merged.

@TheJackiMonster TheJackiMonster merged commit 0203872 into olivierkes:develop Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants