Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing rdb metrics #880

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Add missing rdb metrics #880

merged 1 commit into from
Feb 16, 2024

Conversation

vin01
Copy link
Contributor

@vin01 vin01 commented Feb 15, 2024

these metrics have been added in 7.0 and are very useful in debugging, monitoring.

Reference: redis/redis@56fa48f

@coveralls
Copy link

coveralls commented Feb 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 281

Details

  • 0 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 91.974%
Totals Coverage Status
Change from base Build 277: 0.01%
Covered Lines: 1971
Relevant Lines: 2143
💛 - Coveralls

oliver006
oliver006 reviewed Feb 16, 2024
View reviewed changes
Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Let's give thee metrics a bit more prometheus-friendly names (trailing unit like "keys" or "-total) and then this should be good to go.

exporter/exporter.go Outdated Show resolved Hide resolved
exporter/exporter.go Outdated Show resolved Hide resolved
exporter/exporter.go Outdated Show resolved Hide resolved
oliver006
oliver006 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@oliver006 oliver006 merged commit 227a050 into oliver006:master Feb 16, 2024
5 checks passed
@oliver006
Copy link
Owner

Thanks for the PR!

@oliver006
Copy link
Owner

Released as https://github.com/oliver006/redis_exporter/releases/tag/v1.58.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver006 oliver006 oliver006 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vin01 @coveralls @oliver006