Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Redis Sentinel metrics ckquorum #691

Merged
merged 8 commits into from
Aug 25, 2022

Conversation

opan
Copy link
Contributor

@opan opan commented Aug 15, 2022

Expose new metrics for Redis Sentinel from command SENTINEL CKQUORUM <master-name>

@coveralls
Copy link

coveralls commented Aug 15, 2022

Pull Request Test Coverage Report for Build 1660

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 92.151%

Totals Coverage Status
Change from base Build 1648: 0.04%
Covered Lines: 1808
Relevant Lines: 1962

💛 - Coveralls

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #691 (9391f0f) into master (78f0431) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   88.18%   88.24%   +0.06%     
==========================================
  Files          16       16              
  Lines        1946     1956      +10     
==========================================
+ Hits         1716     1726      +10     
  Misses        154      154              
  Partials       76       76              
Impacted Files Coverage Δ
exporter/exporter.go 91.58% <100.00%> (+0.01%) ⬆️
exporter/sentinels.go 89.16% <100.00%> (+0.87%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oliver006
Copy link
Owner

Thanks for the PR! I'll try to get to reviewing it in the next few days.

@opan
Copy link
Contributor Author

opan commented Aug 15, 2022

@oliver006 Thanks!

exporter/sentinels.go Outdated Show resolved Hide resolved
exporter/sentinels.go Outdated Show resolved Hide resolved
@opan
Copy link
Contributor Author

opan commented Aug 25, 2022

@oliver006 I just push a new commit contains fix for the log debug for masterCkquorum metric

Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One last nit and then this should be good to go.

exporter/sentinels.go Outdated Show resolved Hide resolved
@oliver006 oliver006 merged commit 19f7b03 into oliver006:master Aug 25, 2022
@oliver006
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants