fix #650, add db_keys_cached gauge.

[vixns]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 1572

• 12 of 14 (85.71%) changed or added relevant lines in 2 files are covered.
• 23 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.1%) to 91.975%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
exporter/info.go	10	12	83.33%

Files with Coverage Reduction	New Missed Lines	%
exporter/exporter.go	23	94.61%

Totals
Change from base Build 1549:	-0.1%
Covered Lines:	1788
Relevant Lines:	1944

---

💛 - Coveralls

[codecov]

Codecov Report

Merging #656 (4e5a769) into master (f72af6d) will decrease coverage by 0.26%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
- Coverage   88.24%   87.97%   -0.27%     
==========================================
  Files          16       16              
  Lines        1922     1938      +16     
==========================================
+ Hits         1696     1705       +9     
- Misses        152      156       +4     
- Partials       74       77       +3     

Impacted Files	Coverage Δ
exporter/info.go	95.12% <75.00%> (-0.69%)	⬇️
exporter/exporter.go	91.52% <100.00%> (-0.66%)	⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[oliver006]

Thanks for the PR @vixns !
Can you please fix the linting issue and see if you can bump the test coverage a bit? Thanks!

[oliver006]

There's a coverage check warning here: https://github.com/oliver006/redis_exporter/pull/656/files#diff-01814cc33b1a90b54048d89aaf89507891e8dc68a953a859cdb3b7985b3e906bR110

Which means that none of the tests emit the cached_key metrics.
Did you verify this is working by running it locally? One of the tests should be hitting a KeyDB instance so not clear why this is not covered.
Just want to make sure this is working.

[vixns]

There's a coverage check warning here: https://github.com/oliver006/redis_exporter/pull/656/files#diff-01814cc33b1a90b54048d89aaf89507891e8dc68a953a859cdb3b7985b3e906bR110

Which means that none of the tests emit the cached_key metrics. Did you verify this is working by running it locally? One of the tests should be hitting a KeyDB instance so not clear why this is not covered. Just want to make sure this is working.

Tested with keydb 6.3.1,

[oliver006]

Ah, I think I have an idea what's going on.
Currently, KeyDB instances for tests are using the rather old version 5.3.0 and that might not expose/have the cached key data.

Can you bump that please in the .drone and contrib/docker-compose to 6.3.0 ?

Thanks!

[oliver006]

🚀

[oliver006]

Released as https://github.com/oliver006/redis_exporter/releases/tag/v1.40.0