Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed TestLatencyStats() wrong check #653

Merged
merged 1 commit into from
May 30, 2022

Conversation

filipecosta90
Copy link
Contributor

@filipecosta90 filipecosta90 commented May 30, 2022

This PR fixes an added issue on #652 (comment).

check of failure

$ TEST_REDIS7_URI=redis://127.0.0.1:6379 go test exporter/*.go --test.run TestLatencyStats* -test.v
=== RUN   TestLatencyStats
    info_test.go:135: didn't find aalatency_percentiles_usec
--- FAIL: TestLatencyStats (0.06s)
FAIL
FAIL    command-line-arguments  0.067s
FAIL

check of fix:

$ TEST_REDIS7_URI=redis://127.0.0.1:6379 go test exporter/*.go --test.run TestLatencyStats* -test.v
=== RUN   TestLatencyStats
--- PASS: TestLatencyStats (0.06s)
PASS
ok      command-line-arguments  0.061s

@filipecosta90 filipecosta90 changed the title fixed TestLatencyStats() wrong check. Minor addition to Readme fixed TestLatencyStats() wrong check May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #653 (2385975) into master (29d12ac) will increase coverage by 0.07%.
The diff coverage is 89.89%.

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   88.17%   88.24%   +0.07%     
==========================================
  Files          16       16              
  Lines        1826     1922      +96     
==========================================
+ Hits         1610     1696      +86     
- Misses        145      152       +7     
- Partials       71       74       +3     
Impacted Files Coverage Δ
exporter/metrics.go 90.90% <75.00%> (-3.54%) ⬇️
exporter/info.go 95.81% <91.86%> (-1.18%) ⬇️
exporter/exporter.go 92.17% <100.00%> (+0.01%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@oliver006
Copy link
Owner

Thank you!

@oliver006 oliver006 merged commit f72af6d into oliver006:master May 30, 2022
@filipecosta90 filipecosta90 deleted the fix.latencystats.test branch May 30, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants