Skip to content

Add cmd line option to control redacting of config metrics #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

oliver006
Copy link
Owner

Fixed #609

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1481

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.015%

Totals Coverage Status
Change from base Build 1479: 0.03%
Covered Lines: 1671
Relevant Lines: 1816

💛 - Coveralls

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #611 (18f8833) into master (6ddefae) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   88.02%   88.06%   +0.03%     
==========================================
  Files          16       16              
  Lines        1804     1810       +6     
==========================================
+ Hits         1588     1594       +6     
  Misses        145      145              
  Partials       71       71              
Impacted Files Coverage Δ
exporter/exporter.go 91.90% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddefae...18f8833. Read the comment docs.

@oliver006 oliver006 merged commit a8f5b9c into master Feb 15, 2022
@oliver006 oliver006 deleted the oh_redact_config_metrics branch February 15, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secrets in redis.conf are exposed when exporting config metrics
2 participants