viewertexteditor: Fix incorrect text rendering when pixel aspect ratio not 1 #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Olive is about to undergo some largish code refactoring and I wanted to check on the status of old PRs before we do that. Do you plan to update/continue with the PR? Thanks |
|
It's up to you whether to merge this or not. I think this may be useful. If not then feel free to close this. |
app/node/generator/text/textv3.cpp
Outdated
| @@ -150,11 +150,12 @@ void TextGeneratorV3::GenerateFrame(FramePtr frame, const GenerateJob& job) cons | |||
|
|
|||
| // Draw rich text onto image | |||
| QPainter p(&img); | |||
| p.scale(1.0 / frame->video_params().divider(), 1.0 / frame->video_params().divider()); | |||
| const double par = frame->video_params().pixel_aspect_ratio().toDouble(); | |||
There was a problem hiding this comment.
Long explicit names are prefered so something like pixel_aspect_ratio would be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1844, although it solves the problem with text only and not polygon, shape, and transform