Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Olive plays videos slower than expected #23

Closed
itsmattkc opened this issue Feb 4, 2018 · 5 comments
Closed

Olive plays videos slower than expected #23

itsmattkc opened this issue Feb 4, 2018 · 5 comments

Comments

@itsmattkc
Copy link
Contributor

Without reporting so (no warning about a frame taking longer than expected, i.e. as far as the app is concerned it's realtime), Olive appears to play all video slightly slower than it should.

This is likely either a vsync issue (similar to #20) or a result of Olive's single-threaded nature. Either way this will become increasingly problematic as #4 is finally implemented.

@itsmattkc itsmattkc added the bug label Feb 4, 2018
@itsmattkc
Copy link
Contributor Author

This appears to have lessened since disabling vsync in 40213c0, however it is difficult to actually tell. As a result, I'll leave this issue open and as sound is implemented, it should become more apparent.

@itsmattkc
Copy link
Contributor Author

itsmattkc commented Feb 5, 2018

On a high-end PC, I've observed videos actually playing slightly faster than usual - confirmed by comparing with VLC playback of the same video.

@itsmattkc
Copy link
Contributor Author

With vsync re-enabled, the high-end PC still appears to play clips slightly fast making it unlikely vsync is the culprit. The culprit may instead be power saving functions employed by the laptop that this issue was first observed on. There's no reason Olive should be playing videos faster, and the strangest part is if these videos are playing slower, why is Olive not reporting them? Clearly more testing is required.

@itsmattkc
Copy link
Contributor Author

Disabling vsync has definitely fixed the slowness on the original PC. Olive appears to consistently play videos slightly too fast now.

@itsmattkc
Copy link
Contributor Author

This appears to no longer be a thing and does not seem to have affected audio playback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant