Skip to content

Prevent Recursive Redrawing in AdjustTableSize#4598

Merged
rathboma merged 3 commits intoolifolkerd:masterfrom
schwarmco:fix-4467
Apr 14, 2025
Merged

Prevent Recursive Redrawing in AdjustTableSize#4598
rathboma merged 3 commits intoolifolkerd:masterfrom
schwarmco:fix-4467

Conversation

@schwarmco
Copy link
Contributor

@schwarmco schwarmco commented Oct 12, 2024

Fix #4467
Fix #4599

Copy link
Contributor

@kunaljaykam kunaljaykam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't make changes in dist folder. You can read the contibuting guidelines here: https://tabulator.info/community/pr

image

@schwarmco
Copy link
Contributor Author

Reverted the Build Step - Reset dist Folder to origin/master

@schwarmco
Copy link
Contributor Author

Hi @olifolkerd - any chance this gets merged into a 6.3.1 release soon?

@BartNSTCL
Copy link

Still waiting for this PR to be merged in 6.3.0. Not sure if it was forgotten or what was the issue.

@rathboma
Copy link
Collaborator

I think this looks fine. Going to merge.

Thanks so much for the contribution! @azmy60 and I are online more than Oli -- we work on Beekeeper Studio, and we're helping out on Tabulator because Beekeeper also uses Tabulator, so we want it to be super awesome. :-). So if you need someone, ping us

@rathboma rathboma merged commit 03a7b07 into olifolkerd:master Apr 14, 2025
@BartNSTCL
Copy link

When do you expect a release of this version and will it be 6.3.1? Or has it been released as 6.3.1? Just noticed the date last released was Jan 19. I'm interested in the fix for #4467 which looks like it was included.

@rathboma
Copy link
Collaborator

I'll probably put out a release by the end of the month. Want to circle back with Oli before I do (and currently in the throws of a Beekeeper release).

@Jojoshua
Copy link
Contributor

@rathboma could this be possibly similar? #4142

@azmy60 azmy60 linked an issue Aug 11, 2025 that may be closed by this pull request
@SimonCVenex
Copy link

I'll probably put out a release by the end of the month. Want to circle back with Oli before I do (and currently in the throws of a Beekeeper release).

I'm on Tabulator 6.3.1 (current latest version, released in January 2025).

I'm being hit by the stack size bug that is fixed in this PR. You ( @rathboma ) mentioned above you were hoping to put out a release soon with the fix in it, but it doesn't seem to have happened. Any update on this? I'd prefer to use an official release if it's coming, but the bug is a show-stopper so if there's no release planned, I may have to patch it manually at my end.

Thank you for your work on this library. It's fantastic! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

6 participants