-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the filter or sorting, while pagination is enabled, does not revert the table back to the first page #3671
Comments
Compare #3676 these changes .. I am assuming that it might cause problem in other Modules as well |
@doublehrajput Unfortunately those changes will result in a reset in horizontal scroll position, which is undesirable when not in paginated mode. |
Hey @KarmaProd Thanks for point out the inconsistency here. As much as this is a regression against the previous version. i think it actually highlights a bigger problem with the current design paradigm. At the moment scroll positions are preserved when a sort occurs (on local data) but not pagination. which is making the same action trigger different actions per module. To make things more consistent i will make some improvements in the next update. all modules will maintain their current state on sort/filter and then i will add a Cheers Oli :) |
Actually, I didn't mention something else I noticed. In my stable installation I use tabulator 5.0.7, and this bug is NOT present. But in the http://tabulator.info/docs/5.0/page documentation page the bug IS present. @olifolkerd do you know why? |
Because that uses local pagination not remote pagination, the issue isnt about pagination as such but the data source. a remote data source will result in data being reloaded a local source will result in it being refreshed |
I am upgrading to 5.2.4. Any update about this small bug? By now, I am applying this workaround:
|
I had to do the same as @KarmaProd for workaround. I am using 5.4. It still shows in its docs: |
@olifolkerd Thank you in advance for your help. |
Describe the bug
When using pagination, after changing a filter or sorting, the tabulator page is not restored to first one. Please note that documentation states otherwise, and this behaviour was working in a previous version.
Tabulator Info
5.1.7
Working Example
example of bug: http://tabulator.info/docs/5.1/page
example of working version: http://tabulator.info/docs/4.1/page
To Reproduce
A step by step guide to recreate the issue:
Expected behavior
Page should be restored to page 1, as the documentation clearly states shortly after in that same page:
Note: Changing the filter, sorting or toggling a groups visibility, while pagination is enabled will revert the table back to the first page.
Desktop:
The text was updated successfully, but these errors were encountered: