Skip to content

✨ Handle update failures and improve retry logic #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olibos merged 3 commits into from
Nov 16, 2024
Merged

✨ Handle update failures and improve retry logic #86

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ecc044
✨ Handle update failures and improve retry logic
olibos Nov 16, 2024
4db84ee
✨ Generalize exponential backoff for retry intervals
olibos Nov 16, 2024
fad8f2c
Merge branch 'main' into feature/retry-logic
olibos Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions custom_components/recycle_app/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Custom integration to integrate RecycleApp with Home Assistant."""

import asyncio
from datetime import date, datetime
from datetime import date, datetime, timedelta
import logging

from homeassistant.config_entries import ConfigEntry
Expand All @@ -11,7 +11,7 @@
from homeassistant.helpers.device_registry import DeviceEntryType, DeviceInfo
from homeassistant.helpers.event import async_track_time_change
from homeassistant.helpers.typing import ConfigType
from homeassistant.helpers.update_coordinator import DataUpdateCoordinator
from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, UpdateFailed

from .api import FostPlusApi
from .const import DEFAULT_DATE_FORMAT, DOMAIN
Expand All @@ -21,6 +21,12 @@
_LOGGER = logging.getLogger(__name__)


def _get_next_retry(interval: timedelta | None) -> timedelta:
new_interval = interval * 2 if interval else timedelta(minutes=5)
max_interval = timedelta(hours=1)
return min(new_interval, max_interval)


async def _async_update_listener(hass: HomeAssistant, entry: ConfigEntry) -> None:
"""Handle options update."""
await hass.config_entries.async_reload(entry.entry_id)
Expand Down Expand Up @@ -59,16 +65,28 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
async def async_update_collections() -> dict[str, list[date]]:
"""Fetch data."""
_LOGGER.debug("Update collections")
return await hass.async_add_executor_job(
api.get_collections, zip_code_id, street_id, house_number
)
retry = _get_next_retry(coordinator.update_interval)
try:
coordinator.update_interval = None
return await hass.async_add_executor_job(
api.get_collections, zip_code_id, street_id, house_number
)
except Exception as exception:
coordinator.update_interval = retry
raise UpdateFailed from exception

async def async_update_parks() -> dict[str, dict]:
"""Fetch data."""
_LOGGER.debug("Update recycling parks")
return await hass.async_add_executor_job(
api.get_recycling_parks, recycling_park_zip_code, language
)
retry = _get_next_retry(parks_coordinator.update_interval)
try:
parks_coordinator.update_interval = None
return await hass.async_add_executor_job(
api.get_recycling_parks, recycling_park_zip_code, language
)
except Exception as exception:
parks_coordinator.update_interval = retry
raise UpdateFailed from exception

coordinator = DataUpdateCoordinator(
hass,
Expand Down