Skip to content

Correcting incorrect example #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

michaelciraci
Copy link
Contributor

Right now the examples fail; this fixes the examples.

TODO (check if already done)

  • Add tests
  • Add CHANGELOG.md entry

@michaelciraci
Copy link
Contributor Author

I'm not sure if you'd want to add this to CI/CD to catch this next time, but just let me know.

@oli-obk
Copy link
Owner

oli-obk commented Apr 17, 2025

Hmm... I don't remember why I didn't add them to CI, maybe platform differences? Would be nice to check it, yea

@oli-obk oli-obk merged commit 73554b9 into oli-obk:main Apr 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants