-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor folders and remove CRS #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7f2bb10.
minimal workflow is working. (permanent cluster-mgmt and 1 workload cluster-01, fully automated) Clusters% kubectx | head
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-reviewing again approach outlined in this repo https://github.com/fluxcd/flux2-multi-tenancy I think I got it wrong. In my case
clusters
were no more than just pointers to kustomizations ininfrastructure
.infrastructure
in this example as I understand it now is a collection of "lego" blocks, components that run on the clusters (not "payload"), andclusters
is the assembly of the lego blocks. I also findinfrastructure
word a bit confusing in this context and I think thatplatform
is more appropriate.ClusterResourceSet
is an experimental feature and was never meant to stay in CAPI, however currently there is no fully integrated solution to take its place. This is likely to be that solution one day: https://github.com/Jont828/cluster-api-addon-provider-helmThis will be used in this repo to install Cilium on workload clusters (including the permanent management cluster). It can't be installed with https://fluxcd.io/flux/components/helm/helmreleases/#remote-clusters--cluster-api because it needs dynamic value (api server host and port) which is only known at the runtime. CAAPH can handle this.
Note on cluster index
Cluster index is required for Cilium mesh, but current CAAPH implementation doesn't seem to be able to extract index from the labels.
Moreover, if using labels as a way to pass index there is type mismatch since labels are strings, but Cilium expects it as an integer.
The workaround for now is to duplicate HelmReleaseProxy and hard-code the index :(
id: {{ .ControlPlane.metadata.name | strings.TrimPrefix "cluster-0" }}
failed because "strings" not defined.
id: {{ .ControlPlane.metadata.labels.clusterindex }}
this works, but cilium needs it as integer, while labels need to be strings