Skip to content

Commit

Permalink
Update CONTRIBUTING.md
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielRosenwasser committed Mar 18, 2016
1 parent 28780d6 commit 5fb0f81
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,23 @@

## Contributing fixes to existing samples

A bug must have an issue tracking it in the issue tracker that has been approved (Lable: "help wanted") by the TypeScript team.
A bug must have an issue tracking it in the issue tracker that has been approved (labeled "help wanted") by the TypeScript team.
Your pull request should include a link to the bug that you are fixing.
If you've submitted a PR for a bug, please post a comment in the bug to avoid duplication of effort.

## Contributing new samples

New samples may be accepted, but will need to first be approved (marked as Label: "help wanted" by a TypeScript coordinator) in the suggestion issue.
New samples may be accepted, but will need to first be approved (labeled "help wanted" by a TypeScript coordinator) in the suggestion issue.

For new samples, please provide a detailed explanation of the intended sample, list of technologies or tools used, and an explanation of why existing samples are not sufficient and a new sample is needed.

A sample is meant to showcase a specific technology or toolchain integration with TypeScript; a sample is not meant to be a template that users would use to get a project going.
A sample is meant to showcase a specific technology or toolchain integration with TypeScript; it is not meant to be a template that users would use to get a project going.
A sample should only include tools/technologies that serve the main technology it covers; for instance, a sample for a UI framework should not include a test framework integration.

A sample should be well documented.
Please include comments in `readme.md` explaining why steps are being taken, including in build files if applicable.
A good sample `readme.md` should read like a walkthrough, guiding the reader through different steps of setting up and building the sample.
Please include comments in code as well as content in the a `README.md` explaining why steps are being taken.
Comments should also be included in build files if applicable.
A good sample `README.md` should read like a walkthrough, guiding the reader through different steps of setting up and building the sample.
See [TypeScript quick start samples](https://github.com/Microsoft/TypeScript-Handbook/tree/master/pages/quick-start) for guidance.

A sample should be self-contained.
Expand All @@ -36,4 +37,4 @@ Briefly, this agreement testifies that you are granting us permission to use the
Please submit a Contributor License Agreement (CLA) before submitting a pull request.
You may visit https://cla.microsoft.com to sign digitally.
Alternatively, download the agreement ([Microsoft Contribution License Agreement.docx](https://www.codeplex.com/Download?ProjectName=typescript&DownloadId=822190) or [Microsoft Contribution License Agreement.pdf](https://www.codeplex.com/Download?ProjectName=typescript&DownloadId=921298)), sign, scan, and email it back to <cla@microsoft.com>.
Be sure to include your github user name along with the agreement. Once we have received the signed CLA, we'll review the request.
Be sure to include your GitHub user name along with the agreement. Once we have received the signed CLA, we'll review the request.

0 comments on commit 5fb0f81

Please sign in to comment.