Update dependencies and drop Node.js 8.x / stylelint < 13.0.0 support #123
Conversation
|
See also #124 in case you want to make 10.12.0 the minimum and drop the mkdirp dependency. I haven't tested it but it should work. Not sure if I'll have the time to work on this too, just letting you know :) |
XhmikosR
changed the title
|
I suppose we should release the new major version to match stylelint 13 and drop support for Node 8 as they have done. Then we can just change the stylelint peer dependency to |
|
Technically gulp-stylelint should work with stylelint 10.1.0, though. I don't know all this peerDependencies are hurting my brain :P I feel like we are overcomplicating things. BTW in stylelint 13.0.0 there's no engines property set. |
XhmikosR
changed the title
|
Patch updated. See also #125 |
* eslint 6.8.0 * sinon 8.1.1 * stylelint 13.0.0 * tape 4.13.0
|
I remember that we had a long discussion (#35) about this, and the conclusion was to use peerDependencies 🤷♂ |
|
I'm not against peerDependencies. But since we only test the latest version, I don't know if an older one will break personally. It should be possible to test the other versions too BTW using npm aliases. Anyway, about this PR, if gulp-stylelint works with stylelint 13.0.0, we could just add v13.0.0 like I had in my initial patch |
|
...and keep Node.js 8.x in package.json. |
But then we can't merge #124 because it needs Node.js 10.x I was planning to release these changes as gulp-stylelint@13.0.0 which requires stylelint@13.0.0. Currently we're at v11.0.0, so there will be a version skip. In case anyone needs Node 8.x with Stylelint 13 (which I doubt) we can cheat by releasing gulp-stylelint@12. |
|
In that case I say just do all major changes in one batch. Merge this as is, then #124 and release a new major version. |
|
Released as v13.0.0. Thanks! 🙇 |
@olegskl before merging this, maybe you should reconsider the stylelint peerDependency version? I'm a little lost, because stylelint 13.0.0 might work with Node.js 8.x but the engines version is now 10.x.
Also, I don't know if the old versions work with newer Node.js versions, so maybe this is a good chance to limit/change the peerDependency version?
Do note that for example, stylelint-config-recommended is using
"stylelint": ">=10.1.0".