Wildy slayer #5426
Wildy slayer #5426
Conversation
Apply Sweep Rules to your PR?
|
…into wildy-slayer
…olbot into wildy-slayer
src/lib/openables.ts
Outdated
| { | ||
| name: 'Bird nest (ent)', | ||
| id: 5070, | ||
| openedItem: getOSItem(5070), | ||
| aliases: ['bird nest (ent)', 'ent nest', 'ent bird nest', 'bird nest ent'], | ||
| output: nestTable, | ||
| allItems: nestTable.allItems | ||
| }, |
There was a problem hiding this comment.
Why is this dropping the red egg nest, and being called an ent nest?
src/lib/MUser.ts
Outdated
| hasRingOfWealthI: boolean = false, | ||
| isInWilderness: boolean = false, | ||
| isOnSlayerTask: boolean = false |
There was a problem hiding this comment.
Use a named object so that its obvious which is which when calling it, e.g. buildTertiaryItemChanges({ hasRingOfWealthI: true, inWildy: true, onTask: false });
|
|
||
| let hasRingOfWealthI = user.gear.wildy.hasEquipped('Ring of wealth (i)') && isInWilderness; | ||
| if (hasRingOfWealthI) { | ||
| messages.push('\nYour clue scroll chance is doubled due to wearing a Ring of Wealth (i).'); |
There was a problem hiding this comment.
Just a comment (im not sure), if the newlines are really needed in the messages added in this pr.
There was a problem hiding this comment.
Think I have addressed all your queries, the testers did prefer having the message so they knew it was working for sure. But i can remove it if you think thats best, i only added it from testers feedback
|
Hey @ellipsis, give me a code review (just trying something ignore this) |
1 similar comment
|
Hey @ellipsis, give me a code review (just trying something ignore this) |
|
OK! Reviewing this PR... Responding to this comment by @gc. For more information about Ellipsis, check the documentation. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 863b3bc in 1 minute and 49 seconds
More details
- Looked at
2481lines of code in36files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. /tests/unit/snapshots/clsnapshots.test.ts.snap:90
- Draft comment:
The addition of Dagon'hai items to the Slayer Collection Log is correctly reflected in the snapshot with the count increasing from 70 to 73 items. - Reason this comment was not posted:
Confidence changes required:0%
The PR adds Dagon'hai items to the Slayer Collection Log (CL). The snapshot file for the collection log categories and items should reflect this addition. The snapshot shows that the Slayer category has increased from 70 to 73 items, which is consistent with the addition of three Dagon'hai items. This change is correct and aligns with the PR's intent to add these items to the Slayer CL.
Workflow ID: wflow_pGOHelJ7O79GuX9c
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 5 days left in your free trial, upgrade for $20/seat/month or contact us.
Wildy slayer:
Changes:
@gc I'm completely fine if this isn't done in a way that works for you, this was just a personal fun project mainly with seeing how much I could do with it. Open to changing and moving anything into different PRs if that makes it easier for you.
Summary:
This PR introduces comprehensive Wilderness Slayer features, including new NPCs, items, and task mechanics, deeply integrated into the game's systems.
Key points:
KrystiliaNPC for Wilderness Slayer tasks.larran's keys,slayer enchantments, andring of wealth (i).pkChancefor monsters during Wilderness tasks.Dagon'haiset to Slayer Collection Log.schema.prisma,MUser.ts,CollectionsExport.ts, etc.) to support new features.Generated with ❤️ by ellipsis.dev