Fix parsing of special unit formats #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #276 - update the regex used for feet-inch notation to handle signed ints, and rational parts
Note: the time format HH::mm:ss,nsec is gone now in favor of HH::mm:ss.SSS which better lines up with how times are parsed by Time class.
…d ounces, etc.. This is more in line with how these formats are used in practice. WARNING: If you want precision, don't use these formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oddball formats like ft-in, lbs-oz, and stone-lbs did not handle negative values or when the secondary unit contained a fraction. These would yield incorrect values instead of failing.
fixes #276
fixes #104