Use module prepend #266
Merged
Use module prepend #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubyUnits defines some custom behavior for other classes, which either permit easy conversion into Unit objects or which define custom numeric behavior to allow Numeric objects and Unit objects to interoperate properly. These were previously defined using method aliasing, but there are better ways, like using Module#prepend. Note: the behavior of Numeric#to_unit changed here to be more consistent with how this method behaves in other classes. This is a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RubyUnits defines some custom behavior for other classes, which either permit easy conversion into Unit objects or which define custom numeric behavior to allow Numeric objects and Unit objects to interoperate properly. These were previously defined using method aliasing, but there are better ways, like using Module#prepend.
Note: the behavior of Numeric#to_unit changed here to be more consistent with how this method behaves in other classes. This is a breaking change.