Skip to content

Version upgrade of the maven-scm-provider-svn-commons dependency : 1.12.2 ==> 2.0.0-M3 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

longbeach
Copy link
Contributor

Version upgrade of the maven-scm-provider-svn-commons dependency : 1.12.2 ==> 2.0.0-M3

Follow up to my enhancement request here : #55 (comment)

Directly from my main branch, hope it's ok.
Modified a few classes to use SL4J instead of SCMLogger.
Tests are ok (extended ScmTestCase instead of PlexusTestCase)
Only one doubt : what to do with SvnJavaUpdateCommand.getChangeLogCommand() since AbstractCommand no longer uses ScmLogger ?

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@olamy
Copy link
Owner

olamy commented Feb 28, 2023

Thanks. some tests are now failing is it something you can fix?

@longbeach
Copy link
Contributor Author

Yes, I am working on fixing these annoying tests which, I believe, are failing due to a misconfigured path.

@olamy
Copy link
Owner

olamy commented Mar 1, 2023

Thanks for the hard.
still some failures I can reproduce locally

@longbeach
Copy link
Contributor Author

I ran and fixed the tests on Windows. I was hoping they would succeed on Ubuntu too. I am going to run them on Ubuntu and fix them on that OS too then.

@olamy olamy merged commit e6820c3 into olamy:master Mar 2, 2023
@olamy
Copy link
Owner

olamy commented Mar 2, 2023

@longbeach Thanks a lot. Merci ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants