Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 726 : BackupType - Option to use lower case in URL #745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdaniou
Copy link

@mdaniou mdaniou commented May 3, 2023

Adding a bit of code to lowercase urls all the time. I hope this will answer this issue

Adding a bit of code to lowercase urls all the time.
I hope this will answer this issue
@sethmgray
Copy link

I have similar requirement asking for ability to lower() the backup path. In our case we have Always On AGs that have databases that were not properly cased equivalently between restore operations by dbas and having ability to send at least the database name to lower or upper would help to guarantee the file has some consistent convention making its way to case sensitive systems (storage gateways and s3 in AWS in our case).

@olahallengren
Copy link
Owner

Would you like to have a parameter here to make the directory path lower case or upper case?

@sethmgray
Copy link

Would you like to have a parameter here to make the directory path lower case or upper case?

In our case it's best that the path and database name has separate params to put each to upper/lower, but the full path (including db name) would at least allow for predictable and repeatable casing

@olahallengren
Copy link
Owner

Another option could be to introduce new lower/upper case tokens in these parameters:
https://ola.hallengren.com/sql-server-backup.html#DirectoryStructure
https://ola.hallengren.com/sql-server-backup.html#FileName

@sethmgray
Copy link

sethmgray commented Oct 27, 2024 via email

@olahallengren
Copy link
Owner

I assume the addition of two casing versions of each token would be the most flexible and least/no impact to the procs arguments.

It would be the most flexible, but also quite cumbersome to pass the parameters correctly, especially if you have both standalone databases and databases in availability groups.

The other option would be to introduce two new parameters, @DirectoryStructureCase and @FileNameCase, where NULL is the default (as today), but you could set them to LOWER and UPPER.

@olahallengren olahallengren self-assigned this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants