Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add missing nil check in store.GetStore (come from https://github.com… #2246

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

BananaLF
Copy link
Collaborator

…/cosmos/cosmos-sdk/pull/9354 )

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@BananaLF BananaLF changed the title add missing nil check in store.GetStore (come from https://github.com… fix add missing nil check in store.GetStore (come from https://github.com… Jun 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #2246 (bcd5b2c) into dev (3ae1aa1) will decrease coverage by 2.83%.
The diff coverage is n/a.

❗ Current head bcd5b2c differs from pull request most recent head f290126. Consider uploading reports for the commit f290126 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2246      +/-   ##
==========================================
- Coverage   34.69%   31.86%   -2.84%     
==========================================
  Files         337       50     -287     
  Lines       38501     4805   -33696     
==========================================
- Hits        13358     1531   -11827     
+ Misses      24138     3115   -21023     
+ Partials     1005      159     -846     
Impacted Files Coverage Δ
x/staking/types/msg.go
x/erc20/types/proposal.go
x/evm/types/bloombits.go
x/wasm/client/utils/client_adapter.go
x/evm/watcher/marshal.go
x/wasm/types/params.go
x/erc20/keeper/ibc.go
x/erc20/keeper/proposal.go
x/distribution/keeper/invariants.go
x/wasm/keeper/m1compat.go
... and 277 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xiangjianmeng xiangjianmeng merged commit 9a43f2e into dev Jun 28, 2022
@xiangjianmeng xiangjianmeng deleted the sunstrider/fix-gestore-nil branch June 28, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants