-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Resource method is those explicitly defined only #344
Conversation
For example, `params` method is on every Resource class, but they're not intended to be used as attribute. So, `attributes :params` should work when `prefer_resource_method` is on.
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
==========================================
- Coverage 99.27% 98.73% -0.54%
==========================================
Files 14 14
Lines 548 554 +6
==========================================
+ Hits 544 547 +3
- Misses 4 7 +3
|
This line was for debugging but I forgot to remove it.
Probably there's some better way, but I'd like to prioritize quick release.
On CI, JRuby and codecov checks are failing. |
Hi @okuramasafumi , |
@tientt-holistics Although it's possible, Alba v3 is quite mature now and I'd like people to use it instead of v2. What does prevent you from upgrading? |
I'm in the process of upgrading our project from using Ruby 2.7 to Ruby 3.x. After updating to Ruby 3.x, I will definitely using Alba v3. However, Alba v3 will use |
@tientt-holistics https://rubygems.org/gems/alba/versions/2.4.3 version 2.4.3 was released and I hope it fixes your problem! |
Wow, that was fast. Everything is okay now with the new version. Thank you for your help a lots @okuramasafumi |
For example,
params
method is on every Resource class, but they're not intended to be used as attribute.So,
attributes :params
should work whenprefer_resource_method
is on.Fix #342 #343