Conversation
|
Thank you for the PR, I will take a closer look at this today. |
|
I have had time to look at this now. Sorry for the delay. The changing of the slug is bit more complicated that first glance. There are some extra things to take into account, and could do with a bit of planning. Basically, the tricky part is that we need to properly handle the case where the date of an event changes, and set up a redirect so that existing links shared will not break. This can be done during the import step by tracking the date of existing events with the same ID and creating an Astro redirect rule if this happens. And we could do an extra check here and create a redirect rule at this stage during the import. But we'd need to think about various edge cases, and ideally create a bunch of redirects for when we first create the new slug format. But first we'd need to agree on what the best slug format would look like. I would guess We might even consider rolling this into #62 and somehow more dynamically check for changes. Hope this makes sense, and am happy to collaborate further -- perhaps we can walk through the code together on Discord? |
|
Thank you for the review! I'm happy to send PR in OkTech repository. |
Fixes #69
Add event date to URL slugs to check event date only URL.
Example
Before:
/events/work-spinach-and-dev-containersAfter:
/events/work-spinach-and-dev-containers-2026-01-24