Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip users/groups for datasource okta_app_saml #677

Merged
merged 3 commits into from
Oct 7, 2021
Merged

skip users/groups for datasource okta_app_saml #677

merged 3 commits into from
Oct 7, 2021

Conversation

phi1ipp
Copy link
Contributor

@phi1ipp phi1ipp commented Sep 30, 2021

added skip functionality into datasource okta_app_saml

@phi1ipp
Copy link
Contributor Author

phi1ipp commented Sep 30, 2021

@bogdanprodan-okta , can you please have a look, maybe I'm inventing a bicycle again? :)

I ran in a situation where one of my apps has a lot of users assigned, so data okta_app_saml took forever to get its state. This is to address this situation.

I think that maybe it can be done for other okta_app_xxx as well, but was not sure if I'm going the right way with that.

Thx

@bogdanprodan-okta
Copy link
Contributor

@phi1ipp thanks for the PR. If you don't mind, I'll add these fields to all the app-related data sources in this PR.

@phi1ipp
Copy link
Contributor Author

phi1ipp commented Sep 30, 2021

Sure, @bogdanprodan-okta, thank you!

@bogdanprodan-okta bogdanprodan-okta merged commit 3a090dc into okta:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants