Add pagination when getting user groups #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdanprodan-okta
approved these changes
Aug 30, 2021
|
I felt like including setup for an acceptance test that provisioned 200+ groups might be a bit much so I went with a unit test approach to verify the functionality. If we need to show this working via acceptance tests I can adjust. |
That's fine as it is :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have users with a lot of groups assigned. More than the 200 default limit. When getting groups, we're seeing transient errors due to whether or not a particular group we're interested in is present in that first set of 200. This will use the okta client's built in pagination support to keep fetching groups until there are no more pages.