Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing in @cvirtucio's PR #1626 #1869

Merged
merged 9 commits into from
Jan 10, 2024
Merged

Bringing in @cvirtucio's PR #1626 #1869

merged 9 commits into from
Jan 10, 2024

Conversation

monde
Copy link
Collaborator

@monde monde commented Jan 10, 2024

Bringing in @cvirtucio's PR #1626

Closes #1626

Fixed TestAccResourceOktaAppOauth_customProfileAttributes which was broken on profile json before #1626 started work.

$ for t in `grep "func Test" okta/resource_okta_app_oauth_test.go | awk '{ print $2}'| sed -e 's/(.*//g'`; do
go clean -testcache && TF_ACC=1 go test -tags unit -mod=readonly -test.v -run ^${t}$ ./okta
done
=== RUN   TestAccResourceOktaAppOauth_basic
--- PASS: TestAccResourceOktaAppOauth_basic (11.13s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    11.785s
=== RUN   TestAccResourceOktaAppOauth_refreshToken
    resource_okta_app_oauth_test.go:90: This is an 'Early Access Feature' and needs to be enabled by Okta, skipping this test as it fails when this feature is not available
--- SKIP: TestAccResourceOktaAppOauth_refreshToken (0.00s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    0.653s
=== RUN   TestAccResourceOktaAppOauth_serviceNative
--- PASS: TestAccResourceOktaAppOauth_serviceNative (9.46s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    10.166s
=== RUN   TestAccResourceOktaAppOauth_federationBroker
    resource_okta_app_oauth_test.go:181: This is an 'Early Access Feature' and needs to be enabled by Okta, skipping this test as it fails when this feature is not available
--- SKIP: TestAccResourceOktaAppOauth_federationBroker (0.00s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    0.663s
=== RUN   TestAccResourceOktaAppOauth_customProfileAttributes
--- PASS: TestAccResourceOktaAppOauth_customProfileAttributes (16.80s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    17.458s
=== RUN   TestAccResourceOktaAppOauth_serviceWithJWKS
--- PASS: TestAccResourceOktaAppOauth_serviceWithJWKS (8.16s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    8.829s
=== RUN   TestAccResourceOktaAppOauth_serviceWithJWKSURI
--- PASS: TestAccResourceOktaAppOauth_serviceWithJWKSURI (4.98s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    5.625s
=== RUN   TestAccResourceOktaAppOauth_redirect_uris
--- PASS: TestAccResourceOktaAppOauth_redirect_uris (5.93s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    6.591s
=== RUN   TestAccResourceOktaAppOauth_groups_claim
--- PASS: TestAccResourceOktaAppOauth_groups_claim (6.04s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    6.702s
=== RUN   TestAccResourceOktaAppOauth_timeouts
--- PASS: TestAccResourceOktaAppOauth_timeouts (5.20s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    5.835s
=== RUN   TestAccResourceOktaAppOauth_pkce_required
--- PASS: TestAccResourceOktaAppOauth_pkce_required (5.08s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    5.735s
=== RUN   TestAccResourceOktaAppOauth_config_combinations
    provider_test.go:751: test "TestAccResourceOktaAppOauth_config_combinations" is not VCR compatible
--- SKIP: TestAccResourceOktaAppOauth_config_combinations (0.00s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    0.634s

cvirtucio and others added 9 commits July 7, 2023 09:59
…revents users from explicitly setting it to false after the default of true is applied for browser and client apps)
`TestAccResourceOktaAppOauth_customProfileAttributes` test. Ensuring
that profile json is handled correctly. Hand rolled
`noChangeInObjectFromUnmarshaledJSON` seems to be flawed and TF SDK
helper `structure.SuppressJsonDiff` is better suited.
@monde monde merged commit f4fa3b3 into master Jan 10, 2024
2 checks passed
@monde monde deleted the cvirtucio_1626 branch January 30, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants