okta_app_signon_policy_rule import tests for #1275 #1788

monde · 2023-10-26T00:05:20Z

Adds system attribute to resource okta_app_signon_policy_rule - an Okta API boolean marking this rule as the default for its policy
Adds test demonstrating valid import of a default okta_app_signon_policy_rule
Adds system attribute to resource okta_auth_server_policy_rule - an Okta API boolean marking this rule as the default for its policy
Document system attributes in okta_app_signon_policy_rule and okta_auth_server_policy_rule

Closes #1242
Closes #1245
Closes #1275

I don't think #1275 is still exists. The reporter had to have been on an Okta provider prior to v3.45.0 and since then the rule resource has had a number of updates. Closes #1275

possession. Wrote and ACC for this to check constraints in the future. Closes #1242

is the default policy rule. Closes #1245

Test `TestAccResourceOktaAppSignOnPolicyRule_Issue_1275_default_conditions` was unnecessary.

monde added 2 commits October 25, 2023 16:37

Simple import test for resource okta_app_signon_policy_rule

cdd5a8e

Test for #1275 which couldn't be reproduced.

98c8d58

I don't think #1275 is still exists. The reporter had to have been on an Okta provider prior to v3.45.0 and since then the rule resource has had a number of updates. Closes #1275

monde requested a review from duytiennguyen-okta October 26, 2023 00:05

monde marked this pull request as draft October 26, 2023 00:05

duytiennguyen-okta approved these changes Oct 26, 2023

View reviewed changes

monde added 3 commits October 26, 2023 14:01

1242 is not a bug, they typo'd the constraint as posession and not

b0c7d42

possession. Wrote and ACC for this to check constraints in the future. Closes #1242

possession is hard to spell

4d01f52

Fixes some quirks dealing with the Okta API when the rule imported AND

79ccb57

is the default policy rule. Closes #1245

monde force-pushed the 1275_okta_app_signon_policy_rule_import_default branch from 6c905a8 to 79ccb57 Compare October 26, 2023 22:52

monde mentioned this pull request Oct 26, 2023

Unable to manage Default Catch-all Rule in Application Authentication Policy via Terraform after importing resource into Terraform State #1275

Closed

monde added 2 commits October 27, 2023 16:19

Expose "system" field on resource okta_auth_server_policy_rule

900155a

Expose "system" field on resource okta_app_signon_policy_rule

b68a6b4

Test `TestAccResourceOktaAppSignOnPolicyRule_Issue_1275_default_conditions` was unnecessary.

monde marked this pull request as ready for review October 27, 2023 23:44

monde merged commit a594b88 into master Oct 30, 2023
2 checks passed

monde deleted the 1275_okta_app_signon_policy_rule_import_default branch October 30, 2023 16:17

monde mentioned this pull request Nov 1, 2023

prep release v4.6.0 #1795

Merged

exitcode0 mentioned this pull request Nov 6, 2023

Get okta_app_signon_policy by name #1801

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

okta_app_signon_policy_rule import tests for #1275 #1788

okta_app_signon_policy_rule import tests for #1275 #1788

monde commented Oct 26, 2023 •

edited

Loading

okta_app_signon_policy_rule import tests for #1275 #1788

okta_app_signon_policy_rule import tests for #1275 #1788

Conversation

monde commented Oct 26, 2023 • edited Loading

monde commented Oct 26, 2023 •

edited

Loading