Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show appropriate terraform logo for light and dark themes in README #1574

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

thekbb
Copy link
Contributor

@thekbb thekbb commented May 26, 2023

The README looks janky on GitHub when using the dark theme.
Cursor_and_okta_terraform-provider-okta__Terraform_Okta_provider

This will swap out svg's linked from Hashicorp's terraform brand page based on the users GitHub theme
default light (for monsters that use this):
default-light
default dark:
default-dark

The <picture> element is well understood, GitHub's docs indicate this is the preferred way to get this done.

@virgofx
Copy link
Contributor

virgofx commented May 26, 2023

@thekbb Would it be possible to include the assets locally in this repo instead of a random 3rd party? Then reference them similarly to the old asset.

README.md Outdated Show resolved Hide resolved
@thekbb
Copy link
Contributor Author

thekbb commented May 26, 2023

@thekbb Would it be possible to include the assets locally in this repo instead of a random 3rd party? Then reference them similarly to the old asset.

jinx. I was thinking a similar thing in https://github.com/okta/terraform-provider-okta/pull/1574/files#r1207362748

I'll go with your plan, which is better.

@virgofx
Copy link
Contributor

virgofx commented May 26, 2023

Ah, didn't know these were from Terraform's brand page. I guess it would be okay to leave. My first thought when I saw the domain was like -- what is that? what happens if that 3rd party hosting goes away kind of thing.

@thekbb
Copy link
Contributor Author

thekbb commented May 29, 2023

Ah, didn't know these were from Terraform's brand page. I guess it would be okay to leave. My first thought when I saw the domain was like -- what is that? what happens if that 3rd party hosting goes away kind of thing.

It's still probable that someone at Hashicorp reorganizes their stuff, they'd never imagine people would link to that.

I added it to the repo, and think it's much better. Thank you for the suggestion, @virgofx.

Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome effort @thekbb , thank you so much!

@MikeMondragon-okta MikeMondragon-okta merged commit e64b080 into okta:master Jun 28, 2023
@monde monde mentioned this pull request Jun 29, 2023
@thekbb thekbb deleted the swap-logo-for-theme branch June 30, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants