Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine Okta policy rule profile enrollment resource #1572

Merged
merged 7 commits into from
Jun 5, 2023
Merged

Refine Okta policy rule profile enrollment resource #1572

merged 7 commits into from
Jun 5, 2023

Conversation

monde
Copy link
Collaborator

@monde monde commented May 25, 2023

Original implementation of okta_policy_profile_enrollment was not precise in how it set its arguments and could trigger unexpected drift.

/cc @BalaGanaparthi @emanor-okta @zubinmadon @sebman-metro

monde added 2 commits May 25, 2023 14:52
@monde
Clarify there will alway be one policy rule for a profile enrollment
b101548 
policy. That okta_policy_rule_profile_enrollment is not a true create
but instead update.
@monde
A more precise version of okta_policy_rule_profile_enrollment that only
b7cc946 
sets related arguments if they exist in the TF config.

Closes #1213
Closes #1394
@monde
Copy link
Collaborator Author

monde commented May 25, 2023

@duytiennguyen-okta I'll have to get your help to update test/fixtures/vcr/TestAccOktaPolicyRuleProfileEnrollment/mm-oie-2022-10-07-max.yaml and test/fixtures/vcr/TestAccOktaPolicyRuleProfileEnrollment_Issue1213/mm-oie-2022-10-07-max.yaml the API calls sequences in the resource will have changed.

@MikeMondragon-okta MikeMondragon-okta merged commit 0583cdf into master Jun 5, 2023
@MikeMondragon-okta MikeMondragon-okta deleted the okta_policy_rule_profile_enrollment branch June 5, 2023 15:57
MikeMondragon-okta pushed a commit that referenced this pull request Jun 5, 2023
@monde
Add PR #1572 to release
becd9b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duytiennguyen-okta duytiennguyen-okta duytiennguyen-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monde @duytiennguyen-okta @MikeMondragon-okta