Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okta_brand resource brand_id = default and okta_auth_server_default name = default #1570

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

monde
Copy link
Collaborator

@monde monde commented May 24, 2023

brand_id can be set as default to retrieve the default brand w/o knowing its true ID.

Improved default authorization server behavior for default brand while keeping legacy behavior.

@monde monde marked this pull request as draft May 24, 2023 22:53
@monde
Copy link
Collaborator Author

monde commented May 24, 2023

@duytiennguyen-okta the VCR harness doesn't seem to be dropping files into the fixture folder. For instance, in the example below for mm-oie-2022-10-07-max and the TestAccDataSourceOktaBrand_read test I'd expect to see the file ./test/fixtures/vcr/TestAccDataSourceOktaBrand_read/mm-oie-2022-10-07-max.yaml file written out. But it's not, am I calling the record command correctly? The tests do run and pass, only the yaml is not be written to disk.

$ OKTA_VCR_CASSETTE=mm-oie-2022-10-07-max \
  make test-record-vcr-acc \
  TEST=./okta TESTARGS='-run=TestAccDataSourceOktaBrand_read'

$ OKTA_VCR_CASSETTE=mm-oie-2022-10-07-max \
  make test-record-vcr-acc TEST=./okta \
  TESTARGS='-run=TestAccResourceOktaBrand_import_update'

$ OKTA_VCR_CASSETTE=mm-oie-2022-10-07-max \
  make test-record-vcr-acc \
  TEST=./okta TESTARGS='-run=TestAccResourceOktaBrand_default_brand'

@monde monde marked this pull request as ready for review June 28, 2023 18:58
@monde monde changed the title brand_id can be set as default to retrieve the default brand okta_brand resource brand_id = default and okta_auth_server_default name = default Jun 28, 2023
@MikeMondragon-okta MikeMondragon-okta merged commit bd4cac8 into master Jun 28, 2023
@monde monde deleted the brands_default_id branch June 28, 2023 21:47
@monde monde mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants