Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okta app saml saml signed request enabled #1475

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

monde
Copy link
Collaborator

@monde monde commented Mar 3, 2023

Adding SAML app's settings.signOn.samlSignedRequestEnabled as an saml_signed_request_enabled argument on resource okta_app_saml and as an attribute on data source okta_app_saml. Adds and cleans up documentation.

Closes #1401

$ for t in `grep "func Test" okta/resource_okta_app_saml_test.go okta/data_source_okta_app_saml_test.go  | awk '{ print $2}'| sed -e 's/(.*//g'`; do
TF_ACC=1 go test -tags unit -mod=readonly -test.v -run ^${t}$ ./okta
done
2023/03/03 01:13:22 [INFO]  running with default http client
=== RUN   TestAccAppSaml_conditionalRequire
--- PASS: TestAccAppSaml_conditionalRequire (1.88s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    2.465s
2023/03/03 01:13:26 [INFO]  running with default http client
=== RUN   TestAccAppSaml_invalidURL
--- PASS: TestAccAppSaml_invalidURL (0.18s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    0.551s
2023/03/03 01:13:29 [INFO]  running with default http client
=== RUN   TestAccAppSaml_crud
--- PASS: TestAccAppSaml_crud (119.40s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    119.784s
2023/03/03 01:15:30 [INFO]  running with default http client
=== RUN   TestAccAppSaml_preconfigured
--- PASS: TestAccAppSaml_preconfigured (11.32s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    11.686s
2023/03/03 01:15:43 [INFO]  running with default http client
=== RUN   TestAccAppSaml_userGroups
--- PASS: TestAccAppSaml_userGroups (46.29s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    46.683s
2023/03/03 01:16:32 [INFO]  running with default http client
=== RUN   TestAccAppSaml_inlineHook
--- PASS: TestAccAppSaml_inlineHook (6.91s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    7.283s
2023/03/03 01:13:53 [INFO]  running with default http client
=== RUN   TestAccAppSaml_federationBroker
    resource_okta_app_saml_test.go:309: This is an 'Early Access Feature' and needs to be enabled by Okta, skipping this test as it fails when this feature is not available
--- SKIP: TestAccAppSaml_federationBroker (0.00s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    (cached)
2023/03/03 01:16:42 [INFO]  running with default http client
=== RUN   TestAccResourceOktaAppSaml_timeouts
--- PASS: TestAccResourceOktaAppSaml_timeouts (5.99s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    6.341s
2023/03/03 01:16:49 [INFO]  running with default http client
=== RUN   TestAccAppSaml_certdiff
=== PAUSE TestAccAppSaml_certdiff
=== CONT  TestAccAppSaml_certdiff
--- PASS: TestAccAppSaml_certdiff (44.50s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    44.832s
2023/03/03 01:17:35 [INFO]  running with default http client
=== RUN   TestAccOktaDataSourceAppSaml_read
--- PASS: TestAccOktaDataSourceAppSaml_read (101.09s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    101.465s

This is the next release of okta-sdk-golang v2.17.0
`saml_signed_request_enabled` argument on resource `okta_app_saml` and
as an attribute on data source `okta_app_saml`
Closes #1401
@monde monde requested a review from bretterer March 3, 2023 21:26
@monde monde merged commit d1fa41a into master Mar 3, 2023
@monde monde deleted the okta_app_saml_samlSignedRequestEnabled branch March 7, 2023 00:29
@monde monde mentioned this pull request Mar 7, 2023
@monde
Copy link
Collaborator Author

monde commented Mar 7, 2023

Released in v3.43.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'samlSignedRequestEnabled' argument is missing from okta_app_saml resource
2 participants