Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource okta_app_bookmark authentication_policy argument #1376

Merged
merged 6 commits into from
Nov 17, 2022

Conversation

monde
Copy link
Collaborator

@monde monde commented Nov 17, 2022

Related to Bookmark Application Sign-On Policy #1352
This PR is a continuation of @jakezarobsky-8451's PR #1366 that included:

  • Added authentication_policy argument to resource okta_app_bookmark
  • Updated documentation for resource okta_app_bookmark
  • Start of ITs

Specific to this PR:

  • Clean up original PR
  • Add a specific PR test
  • Add an example config
for t in `grep "func Test" okta/resource_okta_app_bookmark_test.go | awk '{ print $2}'| sed -e 's/(.*//g'`; do
TF_ACC=1 go test -tags unit -mod=readonly -test.v -run ^${t}$ ./okta
done
=== RUN   TestAccAppBookmarkApplication_crud
--- PASS: TestAccAppBookmarkApplication_crud (11.26s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    12.154s
=== RUN   TestAccAppBookmarkApplication_timeouts
--- PASS: TestAccAppBookmarkApplication_timeouts (4.71s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    5.256s
=== RUN   TestAccAppBookmarkApplication_PR1366_authentication_policy
--- PASS: TestAccAppBookmarkApplication_PR1366_authentication_policy (6.76s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    7.195s

@MikeMondragon-okta MikeMondragon-okta force-pushed the jakezarobsky-8451_pull_1366 branch 2 times, most recently from a9c7948 to e5ab232 Compare November 17, 2022 18:58
@monde monde merged commit e24ce9a into master Nov 17, 2022
@monde monde deleted the jakezarobsky-8451_pull_1366 branch November 17, 2022 20:21
@monde monde mentioned this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants