Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add access_token to the provider config #1222

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

ericnorris
Copy link
Contributor

This PR adds the ability to configure the provider with an access token directly, rather than with an API key or a private key.

Note: we (Etsy) have been chatting with you (Okta) directly about authentication changes we may want to submit as a PR - this change is related, but different from what we eventually want. This is more of a short to medium term fix for us while we figure out the applicability of our other desired changes with your team. Thanks!

This commit allows a user to specify an access token, instead of an API
token or private key.
@ericnorris ericnorris marked this pull request as ready for review July 27, 2022 20:41
@monde
Copy link
Collaborator

monde commented Jul 28, 2022

Thanks @ericnorris . I'd like to see some links to the API documentation at developer.okta.com about the authentication mechanism this is making use of. They would be listed in the docs published to the TF registry that are listed in https://github.com/okta/terraform-provider-okta/blob/master/website/docs/index.html.markdown and also in this PR description.

@monde monde self-requested a review July 28, 2022 15:18
@ericnorris
Copy link
Contributor Author

Hey @monde! I've pushed a change adding it to the documentation.

I'd like to see some links to the API documentation at developer.okta.com about the authentication mechanism this is making use of.

This is using the existing OAuth 2.0 client authentication mechanism that is linked in the docs, so I added a bit about when a caller would be using access_token instead of private_key, etc. Feel free to tweak the wording if you have suggestions!

Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @ericnorris

@monde monde merged commit 3e0f43a into okta:master Jul 29, 2022
This was referenced Jul 29, 2022
@monde
Copy link
Collaborator

monde commented Jul 29, 2022

Released in https://github.com/okta/terraform-provider-okta/releases/tag/v3.32.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants