Log a warning when we suppress a 401.

okta · Nov 15, 2022 · 4a66add · 4a66add
1 parent c4a9645
commit 4a66add
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/okta/resource_okta_idp_saml.go b/okta/resource_okta_idp_saml.go
@@ -145,7 +145,7 @@ func resourceIdpSamlRead(ctx context.Context, d *schema.ResourceData, m interfac
 		_ = d.Set("issuer_mode", idp.IssuerMode)
 	}
 	mapping, resp, err := getProfileMappingBySourceID(ctx, idp.Id, "", m)
-	if err := suppressErrorOn401(resp, err); err != nil {
+	if err := suppressErrorOn401("resource okta_idp_saml.user_type_id", m, resp, err); err != nil {
 		return diag.Errorf("failed to get SAML identity provider profile mapping: %v", err)
 	}
 	if mapping != nil {

diff --git a/okta/utils.go b/okta/utils.go
@@ -284,9 +284,11 @@ func suppressErrorOn404(resp *okta.Response, err error) error {
 	return responseErr(resp, err)
 }
 
-// Useful shortcut for suppressing errors from Okta's SDK when a Org does not have permission to access a feature.
-func suppressErrorOn401(resp *okta.Response, err error) error {
+// Useful shortcut for suppressing errors from Okta's SDK when a Org does not
+// have permission to access a feature.
+func suppressErrorOn401(what string, meta interface{}, resp *okta.Response, err error) error {
 	if resp != nil && resp.StatusCode == http.StatusUnauthorized {
+		logger(meta).Warn(fmt.Sprintf("Suppressing %q on %q", "401 Unauthorized", what))
 		return nil
 	}
 	return responseErr(resp, err)