Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit #1

Merged
merged 8 commits into from
Jun 1, 2020
Merged

initial commit #1

merged 8 commits into from
Jun 1, 2020

Conversation

aarongranick-okta
Copy link
Contributor

Copies packages/okta-vue from okta-oidc-js with a few adjustments:

  • uses yarn workspace (instead of lerna). This will hoist dependencies to the top level
  • removes 'prebuild' step from e2e app (using webpack / env)
  • removes 'write-package-info' from library build (using webpack / env)
  • e2e harness app is moved to top-level /e2e directory (instead of being nested under packages/okta-vue). Yarn workspace does not allow nested modules
  • publish script and travis.yml are copied from okta-auth-js. It should have the same release process.

swiftone
swiftone reviewed May 28, 2020
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated
## Minimal reproduction of the problem with instructions
<!--
For bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem.
You could use one of our sample applications to build a reproduction demo: https://github.com/okta?q=samples-js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to actual vue sample?

swiftone
swiftone reviewed May 28, 2020
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated

## Environment

- Package Version:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vue version?

@aarongranick-okta
initial commit: okta-vue
a9cf7be 
* Move module to root
@aarongranick-okta aarongranick-okta force-pushed the ag-OKTA-289828-initial-commit branch from 2d56b11 to a9cf7be Compare May 29, 2020 22:49
@aarongranick-okta aarongranick-okta force-pushed the ag-OKTA-289828-initial-commit branch from 8148953 to 8f521c7 Compare May 29, 2020 23:00
@aarongranick-okta aarongranick-okta merged commit fa19d53 into master Jun 1, 2020
@aarongranick-okta aarongranick-okta deleted the ag-OKTA-289828-initial-commit branch June 1, 2020 17:11
shuowu-okta pushed a commit that referenced this pull request Nov 3, 2020
@danab
Merge pull request #1 from danab/danab-logout-readme
0c09b70 
docs: Updates README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiftone swiftone swiftone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarongranick-okta @swiftone