Fixed type for errorCauses in OktaApiError #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const endpointWithVars = endpoint.replace(/{(\w+)}/g, (match, key) => | ||
| this._encodeParam(vars?.[key]) || match | ||
| ); | ||
| const endpointWithVars = endpoint.replace(/{(\w+)}/g, (match, key) => this._encodeParam(vars?.[key]) || match); |
There was a problem hiding this comment.
Fix linting errors reported during yarn build:openapi after PR #395
test/it/device-api.ts
Outdated
| @@ -41,6 +42,7 @@ describe('Device API', () => { | |||
| await client.deviceApi.deactivateDevice({ | |||
| deviceId: testDevice.id | |||
| }); | |||
| await utils.delay(1000); | |||
There was a problem hiding this comment.
Fix flacky tests
denysoblohin-okta
force-pushed
the
od-error-fix-OKTA-572970
branch
from
f57f1a5 to
cfe395a
Compare
shuowu-okta
approved these changes
Jun 27, 2023
Closed
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type fix:
errorCausesofOktaApiErrorshould have type{errorSummary: string}[], notstringhttps://github.com/okta/okta-sdk-nodejs/pull/397/files#diff-392f545291dc836e0a38e75af8285b4f4bfdcd1477d2570ad54ecaa2032045ed
Resolves #374
Copy of #377
Internal ref: OKTA-572970