Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix model hierarchy for DeviceAccessPolicyRuleCondition (by upgrading to openapi@2.9.2) #293

Closed
wants to merge 3 commits into from
Closed

Fix model hierarchy for DeviceAccessPolicyRuleCondition (by upgrading to openapi@2.9.2) #293

wants to merge 3 commits into from

Conversation

oleksandrpravosudko-okta
Copy link
Contributor

@oleksandrpravosudko-okta oleksandrpravosudko-okta commented Nov 18, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

  • add integration test for updating Authenticator

Reviewers

eng-prod-CI-bot-okta pushed a commit that referenced this pull request Nov 30, 2021
@oleksandrpravosudko-okta @eng-prod-CI-bot-okta
fix: set correct ancestor for DeviceAccessPolicyRuleCondition
4e7e33c 
OKTA-447641
<<<Jenkins Check-In of Tested SHA: aab1e80 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 10
PR Link: "#293"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuowu shuowu shuowu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandrpravosudko-okta @shuowu @eng-prod-CI-bot-2-okta