Fix Collection async iteration where only one element is in the collection #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction `done` was set to true even if there's `item` was a valid object - causing "for await...of" to fail.
|
The failing tests are no feature of this PR. |
|
Thanks for the PR @welljsjs ! While our product people consider your request, would you be willing to sign and submit a CLA for us? https://developer.okta.com/cla/ |
|
You should just have received a copy of the CLA @shuowu . |
|
Thanks for signing the CLA! Then I'll need to take over your PR to add/run tests to pass the internal CI process. |
|
New PR created for CI purpose. #193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
donewas set to true even ifitemwas a valid object - causing "for await...of" to fail.Fixes #192