Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework polymorphic deserialization to use built-in support in OpenAPI generator #957

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

arvindkrishnakumar-okta
Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta commented Oct 19, 2023

Issue(s)

Description

Original PR at #948

Thanks @clementdenis

  • Rework polymorphic deserialization
  • Add required code in pojo.mustache (copied from current version of OpenAPI generator) to add polymorphic annotations to model classes
  • Remove now useless custom deserializers, *ApiHelper classes and HelperUtil
  • Update README with modified snippets

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

… generator (#948)

Rework polymorphic deserialization
- Add required code in pojo.mustache (copied from current version of OpenAPI generator) to add polymorphic annotations to model classes
- Remove now useless custom deserializers, *ApiHelper classes and HelperUtil
- Update README with modified snippets

Co-authored-by: Arvind Krishnakumar <61501885+arvindkrishnakumar-okta@users.noreply.github.com>
@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title Rework polymorphic deserialization to use built-in support in OpenAPI… Rework polymorphic deserialization to use built-in support in OpenAPI generator Oct 19, 2023
@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit 8e5bbca into master Nov 7, 2023
9 checks passed
@arvindkrishnakumar-okta arvindkrishnakumar-okta deleted the ak_merge_issue_948 branch November 7, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants