Creating an OpenIDConnectApplication using private_key_jwt and JWKS #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OIdCApplicationBuilder.setJwks
OIdCApplicationBuilder => OIDCApplicationBuilder DefaultOIdCApplicationBuilder => DefaultOIDCApplicationBuilder
sergiishamrai-okta
requested review from
arvindkrishnakumar-okta and
VitaliiTytarenko-okta
arvindkrishnakumar-okta
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
GH issue: #566
Description
User must be able to use
OIdCApplicationBuilderand set Jwks keys.Fix the typo in class names. OIdC should change to OIDC in
OIdCApplicationBuilderandDefaultOIdCApplicationBuilderclass names.Write UT and ITs that tests the added setJwks(..) helper method.
Category