Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Mgmt SDK - Incorrect method param type in UserBuilder::setProvider() #567

Merged
merged 4 commits into from
Mar 29, 2021

Conversation

sergiishamrai-okta
Copy link
Contributor

@sergiishamrai-okta sergiishamrai-okta commented Mar 26, 2021

Issue:

OKTA-381889

Description

UserBuilder method setProvider must accept AuthenticationProvider instead of a boolean.

Create User with Authentication Provider

Category

  • Bugfix
  • Unit Test(s)
  • Documentation

@codecov-io
Copy link

codecov-io commented Mar 26, 2021

Codecov Report

Merging #567 (9842a1f) into master (c1ce4fb) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #567      +/-   ##
============================================
+ Coverage     81.31%   81.47%   +0.16%     
- Complexity     1001     1006       +5     
============================================
  Files           122      122              
  Lines          3328     3330       +2     
  Branches        421      422       +1     
============================================
+ Hits           2706     2713       +7     
+ Misses          434      429       -5     
  Partials        188      188              
Impacted Files Coverage Δ Complexity Δ
...com/okta/sdk/impl/resource/DefaultUserBuilder.java 83.17% <100.00%> (+6.03%) 37.00 <2.00> (+5.00)
...com/okta/sdk/impl/config/YAMLPropertiesSource.java 84.61% <0.00%> (-2.57%) 11.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ce4fb...9842a1f. Read the comment docs.

Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a minor comment.

@sergiishamrai-okta sergiishamrai-okta merged commit 7a8bf76 into master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants