Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing spec inconsistencies with Open API repo spec (v2.3.0) #558

Merged
merged 40 commits into from
Mar 22, 2021

Conversation

sergiishamrai-okta
Copy link
Contributor

@sergiishamrai-okta sergiishamrai-okta commented Mar 15, 2021

Java SDK uses a local copy of the Open API spec, by the original design. This PR contains fixes in swagger code generator classes and templates to address all inconsistencies with OpenAPI spec.

Issue(s)

OKTA-349906

Description

Category

  • Bugfix
  • Enhancement
  • Unit Test(s)

@sergiishamrai-okta sergiishamrai-okta marked this pull request as draft March 15, 2021 13:37
@codecov-io
Copy link

codecov-io commented Mar 15, 2021

Codecov Report

Merging #558 (abc19b3) into master (077279d) will decrease coverage by 0.13%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #558      +/-   ##
============================================
- Coverage     81.40%   81.26%   -0.14%     
+ Complexity      998      997       -1     
============================================
  Files           122      122              
  Lines          3318     3320       +2     
  Branches        418      419       +1     
============================================
- Hits           2701     2698       -3     
- Misses          428      434       +6     
+ Partials        189      188       -1     
Impacted Files Coverage Δ Complexity Δ
...com/okta/sdk/impl/resource/DefaultUserBuilder.java 77.14% <86.66%> (ø) 32.00 <10.00> (ø)
...a/sdk/impl/resource/AbstractPropertyRetriever.java 75.00% <100.00%> (+0.40%) 52.00 <0.00> (+1.00)
...in/java/com/okta/sdk/impl/ds/DefaultDataStore.java 78.18% <0.00%> (-2.28%) 66.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 077279d...abc19b3. Read the comment docs.

@arvindkrishnakumar-okta
Copy link
Contributor

Can you attach a diff of the API changes reported by japicmp plugin?

@arvindkrishnakumar-okta
Copy link
Contributor

arvindkrishnakumar-okta commented Mar 17, 2021

Please add a note to the PR description (or title) on which specific Open API spec version we're syncing the Java SDK spec to (v2.3?).

@sergiishamrai-okta sergiishamrai-okta changed the title Addressing spec inconsistencies with Open API repo spec Addressing spec inconsistencies with Open API (v2.3.0) repo spec Mar 17, 2021
@sergiishamrai-okta
Copy link
Contributor Author

Japicmp report:

japicmp.txt

@sergiishamrai-okta sergiishamrai-okta changed the title Addressing spec inconsistencies with Open API (v2.3.0) repo spec Addressing spec inconsistencies with Open API repo spec (v2.3.0) Mar 17, 2021
@arvindkrishnakumar-okta
Copy link
Contributor

Japicmp report:

japicmp.txt

html file please? it would be more readable.

Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also write ITs for the new APIs that are brought in with this spec update (wherever possible).

Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please double check if we've added ITs (wherever possible) for all the new models introduced with this spec update.

@sergiishamrai-okta sergiishamrai-okta merged commit e456623 into master Mar 22, 2021
@arvindkrishnakumar-okta arvindkrishnakumar-okta deleted the okta-349906-open-api branch March 22, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants