-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing spec inconsistencies with Open API repo spec (v2.3.0) #558
Conversation
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
============================================
- Coverage 81.40% 81.26% -0.14%
+ Complexity 998 997 -1
============================================
Files 122 122
Lines 3318 3320 +2
Branches 418 419 +1
============================================
- Hits 2701 2698 -3
- Misses 428 434 +6
+ Partials 189 188 -1
Continue to review full report at Codecov.
|
Can you attach a diff of the API changes reported by japicmp plugin? |
Please add a note to the PR description (or title) on which specific Open API spec version we're syncing the Java SDK spec to (v2.3?). |
Japicmp report: |
html file please? it would be more readable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also write ITs for the new APIs that are brought in with this spec update (wherever possible).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please double check if we've added ITs (wherever possible) for all the new models introduced with this spec update.
Java SDK uses a local copy of the Open API spec, by the original design. This PR contains fixes in swagger code generator classes and templates to address all inconsistencies with OpenAPI spec.
Issue(s)
OKTA-349906
Description
Category