Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PolicyRules IT failures #421

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

arvindkrishnakumar-okta
Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta commented Jun 30, 2020

Issue(s)

Description

Fixed failures in PolicyRules Integration tests.

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Configuration Change
  • Versioning Change
  • Unit Test(s)
  • Documentation

@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title fix PolicyRulesIT test failure Fix PolicyRulesIT test failures Jun 30, 2020
@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title Fix PolicyRulesIT test failures Fix PolicyRules IT failures Jun 30, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2020

Codecov Report

Merging #421 into master will increase coverage by 0.80%.
The diff coverage is 77.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #421      +/-   ##
============================================
+ Coverage     70.91%   71.71%   +0.80%     
- Complexity     1127     1283     +156     
============================================
  Files           120      129       +9     
  Lines          3624     4172     +548     
  Branches        566      677     +111     
============================================
+ Hits           2570     2992     +422     
- Misses          868      933      +65     
- Partials        186      247      +61     
Impacted Files Coverage Δ Complexity Δ
...k/impl/resource/DefaultOIdCApplicationBuilder.java 57.44% <57.44%> (ø) 15.00 <15.00> (?)
.../impl/resource/DefaultOktaSignOnPolicyBuilder.java 67.74% <67.74%> (ø) 8.00 <8.00> (?)
...mpl/resource/DefaultPasswordPolicyRuleBuilder.java 73.07% <73.07%> (ø) 15.00 <15.00> (?)
...kta/sdk/impl/resource/DefaultGroupRuleBuilder.java 76.47% <76.47%> (ø) 15.00 <15.00> (?)
...a/sdk/impl/resource/DefaultApplicationBuilder.java 78.57% <78.57%> (ø) 12.00 <12.00> (?)
...ta/sdk/impl/resource/DefaultPolicyRuleBuilder.java 80.95% <80.95%> (ø) 9.00 <9.00> (?)
.../impl/resource/DefaultSignOnPolicyRuleBuilder.java 84.14% <84.14%> (ø) 28.00 <28.00> (?)
...m/okta/sdk/impl/resource/DefaultPolicyBuilder.java 86.66% <86.66%> (ø) 11.00 <11.00> (?)
...dk/impl/resource/DefaultPasswordPolicyBuilder.java 88.96% <88.96%> (ø) 44.00 <44.00> (?)
...okta/sdk/impl/ds/DefaultDiscriminatorRegistry.java 80.76% <0.00%> (-15.39%) 6.00% <0.00%> (-1.00%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd43772...4ac2975. Read the comment docs.

@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit 83acdc8 into master Jun 30, 2020
@arvindkrishnakumar-okta arvindkrishnakumar-okta deleted the fix_policy_builder_it_failure branch June 30, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants