Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OKTA-289659: Add Event Hooks Integration Tests #399
OKTA-289659: Add Event Hooks Integration Tests #399
Changes from 13 commits
121f894
988c11e
497d2d1
6d8456f
7a8bb6f
76c5050
85c50d7
9492844
b3e87de
0907206
5deba2f
39128ab
08c4ede
7478d82
e7e519e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user.type seems a bit redundant, maybe just tag it with
user
?(maybe there are a bunch of other user type objects 🤷)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed :)
UserType
andUserTypeList
are the only classes in packagecom.okta.sdk.resource.user.type
.Will consider moving it to a different package (say
com.okta.sdk.resource.user
) as theuser.type
seems redundant. Will do this as part of separate PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://oktainc.atlassian.net/browse/OKTA-305898 created to address this improvement.