-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OKTA-289657: Add Factors API Integration Tests #391
Merged
arvindkrishnakumar-okta
merged 9 commits into
dev_openapi_v2.0.0_major_rel
from
okta-289657-add-factors-integration-tests
Jun 17, 2020
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9b71d9a
added integration tests for Factors
arvindkrishnakumar-okta 731d4c5
refactoring done
arvindkrishnakumar-okta 172f84c
removed tests on factors that will not be enabled in org by default
arvindkrishnakumar-okta e2f2e65
Merge branch 'dev_openapi_v2.0.0_major_rel' into okta-289657-add-fact…
arvindkrishnakumar-okta 022a087
merged with updates from head of dev_openapi_v2.0.0_major_rel branch
arvindkrishnakumar-okta 8bf3a34
Merge branch 'dev_openapi_v2.0.0_major_rel' into okta-289657-add-fact…
arvindkrishnakumar-okta 1712872
Merge branch 'dev_openapi_v2.0.0_major_rel' into okta-289657-add-fact…
arvindkrishnakumar-okta 358c56c
Merge branch 'dev_openapi_v2.0.0_major_rel' into okta-289657-add-fact…
arvindkrishnakumar-okta 457383e
address review comment - renamed test
arvindkrishnakumar-okta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a little overlap with the
activateTotpFactor
for this one, maybe changing the name to include GoogleTotp would make it more clear (if that is the goal of this test)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, yeah that's the idea of this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed test to
testGoogleTotpUserFactorCreation
.