Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change to allow reading in scopes from YAML list #379

Merged
merged 1 commit into from
May 22, 2020
Merged

Minor change to allow reading in scopes from YAML list #379

merged 1 commit into from
May 22, 2020

Conversation

kenyattaclark
Copy link
Contributor

I encountered an issue using the okta.yaml and OAuth 2.0 and specifying multiple scopes. The DefaultClientBuilder assumes that the scopes will be space delimited but the YAMLPropertiesSource loads the scopes into a comma delimited property. I made a slight change to accommodate space and comma delimited scopes properties.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #379 into master will decrease coverage by 3.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #379      +/-   ##
============================================
- Coverage     70.91%   67.16%   -3.76%     
+ Complexity     1127     1058      -69     
============================================
  Files           120      120              
  Lines          3624     3624              
  Branches        566      566              
============================================
- Hits           2570     2434     -136     
- Misses          868      995     +127     
- Partials        186      195       +9     
Impacted Files Coverage Δ Complexity Δ
...com/okta/sdk/impl/client/DefaultClientBuilder.java 67.28% <100.00%> (ø) 40.00 <0.00> (ø)
...om/okta/sdk/impl/http/authc/SswsAuthenticator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...om/okta/sdk/impl/resource/DefaultGroupBuilder.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...ava/com/okta/sdk/impl/error/DefaultErrorCause.java 0.00% <0.00%> (-87.50%) 0.00% <0.00%> (-5.00%)
...a/sdk/impl/resource/DefaultExtensibleResource.java 0.00% <0.00%> (-80.00%) 0.00% <0.00%> (-2.00%)
...ta/sdk/impl/ds/DefaultCacheRegionNameResolver.java 25.00% <0.00%> (-75.00%) 1.00% <0.00%> (-1.00%)
...va/com/okta/sdk/impl/ds/cache/ReadCacheFilter.java 42.85% <0.00%> (-57.15%) 1.00% <0.00%> (-2.00%)
...a/com/okta/sdk/impl/resource/ReferenceFactory.java 50.00% <0.00%> (-50.00%) 1.00% <0.00%> (-1.00%)
...om/okta/sdk/impl/resource/DefaultVoidResource.java 40.00% <0.00%> (-40.00%) 1.00% <0.00%> (-1.00%)
...com/okta/sdk/impl/resource/DefaultUserBuilder.java 46.59% <0.00%> (-30.69%) 16.00% <0.00%> (-11.00%)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa4308...c419678. Read the comment docs.

@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit e17cd15 into okta:master May 22, 2020
@kenyattaclark kenyattaclark deleted the feature_yaml-scopes-list branch May 22, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants