-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAuth2 Support #354
Add OAuth2 Support #354
Conversation
api/src/main/java/com/okta/sdk/authc/credentials/OAuth2ClientCredentials.java
Outdated
Show resolved
Hide resolved
impl/src/main/java/com/okta/sdk/impl/client/DefaultClientBuilder.java
Outdated
Show resolved
Hide resolved
impl/src/main/java/com/okta/sdk/impl/client/DefaultClientBuilder.java
Outdated
Show resolved
Hide resolved
impl/src/main/java/com/okta/sdk/impl/client/DefaultClientBuilder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
integration-tests/src/test/groovy/com/okta/sdk/tests/it/util/ClientProvider.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
impl/src/main/java/com/okta/sdk/impl/api/OAuth2ApiClientCredentialsResolver.java
Outdated
Show resolved
Hide resolved
impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java
Outdated
Show resolved
Hide resolved
impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java
Outdated
Show resolved
Hide resolved
impl/src/main/java/com/okta/sdk/impl/oauth2/OAuth2ClientCredentials.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple minor items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot!
Make sure CI is green and merge it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Lots of work has been done here! Thanks!
impl/src/main/java/com/okta/sdk/impl/http/authc/OAuth2RequestAuthenticator.java
Show resolved
Hide resolved
impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java
Show resolved
Hide resolved
impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor notes but overall it looks good!
…taken care in a new PR
No description provided.